-
Notifications
You must be signed in to change notification settings - Fork 70
Return enum elements for overlap, and adapt ITF tests #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After today's meeting I've checked EnumX and it looks pretty cool.
@lucaferranti What's you opinion on giving it a try? |
@lbenet sorry for the delay in answering, I didn't notice the comment, I think we could give it a try, but does it have a significant advantage wrt returning a symbol? |
well we can try, it's not a biggie :) |
I tested using EnumX.jl: it corresponds to what we have in this PR, with a nicer interface, in the sense that only |
@lbenet sure! |
I think this is ready @lucaferranti. Shall we backport it in an adapted form to master? |
@lbenet LGTM, merging. don't have strong opinions on whether or not we should backport this to master and release a new patch release. If 1.0-dev is going to be merged "soon", then I think we can wait. |
No description provided.