REPL: make DictCompletion context module aware #34908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
changed the title
aviatesk
force-pushed
the
avi/dictcompinmod
branch
from
6b4bbb1 to
dc31e2e
Compare
aviatesk
force-pushed
the
avi/dictcompinmod
branch
2 times, most recently
from
16dcaca to
a0346ae
Compare
aviatesk
force-pushed
the
avi/dictcompinmod
branch
from
a0346ae to
129e04f
Compare
|
@pfitzseb @StefanKarpinski @KristofferC any of you could give a review on this ? This change doesn't change any behaviour of usual REPL process (where we currently don't have module switching support), but should help other REPL environments where |
aviatesk
force-pushed
the
avi/dictcompinmod
branch
from
129e04f to
c0b3678
Compare
|
I've never touched |
|
Thanks, @KristofferC! |
|
thanks you guys ! |
oxinabox
pushed a commit
to oxinabox/julia
that referenced
this pull request
Apr 8, 2020
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
staticfloat
pushed a commit
that referenced
this pull request
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
DictCompletions aware of a context-module.Certain tools (like Juno, Debugger.jl etc) use
REPLCompletionsin a way that completions are generated in a context of a module other thanMain, and can benefit from this change.Not breaking at all, since
context_moduledefaults toMain.