Skip to content

Hide unsafe constructors of IOStream #58023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Hide unsafe constructors of IOStream #58023

wants to merge 1 commit into from

Conversation

jakobnissen
Copy link
Member

Closes #58021

@nsajko nsajko added the needs news A NEWS entry is required for this change label Apr 6, 2025
nsajko
nsajko approved these changes Apr 6, 2025
View reviewed changes
Copy link
Contributor

@nsajko nsajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems no package uses the deleted constructor methods:

@jakobnissen
Copy link
Member Author

@nsajko Looks to me like some packages ARE using it: https://juliahub.com/ui/Search?type=code&q=IOStream(%22

@jakobnissen jakobnissen marked this pull request as draft April 7, 2025 09:26
@jakobnissen
Copy link
Member Author

I think I need to figure out what on Earth IOStream("") actually does before figuring out if it's non-breaking to remove it.

@jakobnissen jakobnissen added the io Involving the I/O subsystem: libuv, read, write, etc. label Apr 7, 2025
@nsajko
Copy link
Contributor

nsajko commented Apr 9, 2025

Perhaps remove the two-arg methods in this PR (those seem unused among the packages), leaving the single-arg method for a future PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsajko nsajko nsajko approved these changes

Assignees
No one assigned
Labels
io Involving the I/O subsystem: libuv, read, write, etc. needs news A NEWS entry is required for this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IOStream exposes unsafe constructor
2 participants
@jakobnissen @nsajko