increase CI timeout #260
Closed
increase CI timeout #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think cloning taking 10 minutes is the unreasonable bit here. |
|
I agree, but I've seen similar cloning times on other repos as well, and I'm uncertain if there's anything that we can do to reduce it |
|
In this PR cloning took one second. I don't think it makes sense to increase the timeout for a network glitch, if something got stuck in a single job, 30 minutes is as good as 6 hours |
|
Interesting, thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen e.g. in https://github.com/JuliaMath/FFTW.jl/actions/runs/4296128646/jobs/7487464311, cloning the repo may take close to 10 minutes, so setting a timeout of 10 minutes is unreasonable. This PR increases the timeout to 30 minutes.