Fixes for julia 0.7/1.0

[donm]

No description provided.

[codecov]

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #32   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          61     63    +2     
=====================================
+ Hits           61     63    +2

Impacted Files	Coverage Δ
src/trig.jl	100% <100%> (ø)	⬆️
src/Tau.jl	100% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5979d20...7dc30e3. Read the comment docs.

[waldyrious]

Thanks for the contribution! Do you know if the 0.5 failures are known issues — perhaps something generic related to running Julia in Travis? I don't think it should have become a problem without any changes in the actual code...

[donm]

Sure! I'm not sure about the 0.5 errors and didn't dig into it very much. I asked at the upgradathon if maintaining compatibility with old versions of Julia was a goal, and Simon B. said not really because users of old versions of Julia would still be handed the old version of the library. But if its a goal for Tau.jl to be compatible with 0.5, I can look into it some more.

[waldyrious]

Nah, it's not a big deal. I would just have preferred if it could be avoided easily.

The error seems pretty generic, so I believe it's possible that many of the packages aiming to maintain 0.5 compatibility (arguably not that many anyway) would be facing this issue. If it turned out to be something someone already knew how to fix, that'd be ideal. Otherwise, I wouldn't bother digging into it.

On a separate note, do you think you could integrate the changes to appveyor.yml I introduced in #30? Or would you prefer to have this PR merged this first, and we'd make that change afterwards?

[donm]

I don't mind integrating the appveyor changes at all. It's up to you if we do it as part of this PR. I'll try to do that in the next day or two--if this PR isn't merged by the time I get to it, then I'll cherry-pick that work and merge it here.

[waldyrious]

I think it makes sense to do those changes as part of this PR. Feel free to integrate them at your leisure :)

[waldyrious]

I just integrated the appveyor.yml changes, so this is ready to merge -- thanks again for the PR!

[donm]

Thanks for doing that, and sorry I didn't get to it as quickly as I thought I would.

[waldyrious]

No worries, you did the bulk of the work on this PR -- it was only fair that someone else do the work of integrating changes made elsewhere ;)