Skip to content

Add documentation #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Add documentation #47

merged 2 commits into from
Feb 28, 2023

Conversation

devmotion
Copy link
Member

Fixes #43.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 95.23% // Head: 95.23% // No change to project coverage 👍

Coverage data is based on head (c0eb021) compared to base (6346620).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files           1        1           
  Lines          21       21           
=======================================
  Hits           20       20           
  Misses          1        1           
Impacted Files Coverage Δ
src/Tau.jl 95.23% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/Tau.jl Outdated
Comment on lines 56 to 64
"""
sinτ(x)
sintau(x)

Compute ``\\sin(\\tau x)`` more accurately than `sin(tau*x)`, especially for large `x`.

See also: `costau`, `sincostau`.
"""
function sintau end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we cannot find documentation for sinτ.

help?> sintau
search: sintau sincostau isinteractive

  sinτ(x)
  sintau(x)

  Compute \sin(\tau x) more accurately than sin(tau*x), especially for large x.

  See also: costau, sincostau.

help?> sinτ
"sinτ" can be typed by sin\tau<tab>

search: sinτ sincosτ sinh sind sinc sin sinpi sincos sintau sincosd sincospi sincostau using isinf asinh asind asin isinteger isinteractive thisind sign signed Signed signbit significand islink isfinite occursin Unsigned unsigned missing Missing lastindex MissingException VERSION versioninfo

  No documentation found.

  Tau.sinτ is a Function.

I think sinτ should be removed (#49), so removing sinτ in the docstring would be better.

Suggested change
"""
sinτ(x)
sintau(x)
Compute ``\\sin(\\tau x)`` more accurately than `sin(tau*x)`, especially for large `x`.
See also: `costau`, `sincostau`.
"""
function sintau end
"""
sintau(x)
Compute ``\\sin(\\tau x)`` more accurately than `sin(tau*x)`, especially for large `x`.
See also: `costau`, `sincostau`.
"""
function sintau end

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected with the latest commit (c0eb021), apparently one has to add the docstring to the "original" function, not its alias.

Copy link

@hyrodium hyrodium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devmotion devmotion merged commit acc9bac into master Feb 28, 2023
@devmotion devmotion deleted the dw/docs branch February 28, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the functions
2 participants