Short-circuit update_clims if not necessary
#4743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BioTurboNick
changed the title
update_clims if not necessaryupdate_clims if not necessary
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4743 +/- ##
=======================================
Coverage 90.37% 90.37%
=======================================
Files 40 40
Lines 8735 8737 +2
=======================================
+ Hits 7894 7896 +2
Misses 841 841
☔ View full report in Codecov by Sentry. |
|
The nightly failure seems unrelated. The format checker really needs a way to indicate trailing spaces. |
t-bltg
approved these changes
May 10, 2023
BeastyBlacksmith
pushed a commit
that referenced
this pull request
May 25, 2023
BeastyBlacksmith
added a commit
that referenced
this pull request
May 26, 2023
…t) (#4738) * CompatHelper: bump compat for StatsBase to 0.34, (keep existing compat) * Plots 1.38.11 * Fix bar plot vector attribute with missing values (#4736) * Fix bar plot vector attribute with missing values * format --------- Co-authored-by: Simon Christ <[email protected]> * dev [skip ci] * Short-circuit `update_clims` if not necessary (#4743) * Fix straightline filling for PGFPlotsX backend (#4746) * fill whole line * adjust to PGFPlotsX v1.6 * Update src/backends/pgfplotsx.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * remove linebreak * remove another linebreak * avoid colon in title * Plots 1.38.12 * dev [skip ci] * Fix UnitfulExt for PGFPlotsX take 2 (#4747) * tests and migrate unitformat * fix tests * format * fix tests * adjust empty label case * add imports * add compat * ditch 1.6 * Revert "ditch 1.6" This reverts commit 1f0ce95. * change imports * fix ci config --------- Co-authored-by: CompatHelper Julia <[email protected]> Co-authored-by: Simon Christ <[email protected]> Co-authored-by: Yuval <[email protected]> Co-authored-by: Simon Christ <[email protected]> Co-authored-by: Nicholas Bauer <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially fixes #4742 .
Attribution