Skip to content

get rid of Pkg dependency #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

KristofferC
Copy link
Contributor

we can use Base.pkgversion if we restrict ourselves to julia 1.9+

we can use `Base.pkgversion` if we restrict ourselves to julia 1.9+
@KristofferC
Copy link
Contributor Author

@NHDaly, do you still have commit access to this repo?

@NHDaly
Copy link
Member

NHDaly commented Sep 16, 2024

Looks to have some failures on nightly, but I assume they're unrelated? Can you confirm?:

macro preserves comments 1: Test Failed at /home/runner/work/AutoHashEquals.jl/AutoHashEquals.jl/test/runtests.jl:79
  Expression: plain(#= /home/runner/work/AutoHashEquals.jl/AutoHashEquals.jl/test/runtests.jl:79 =# @doc(T23)) == "a comment\n"
   Evaluated: "Base.Docs.DocStr(svec(\"a comment\"), nothing, Dict{Symbol, Any}(:typesig => Union{}, :module => Main.runtests, :linenumber => 75, :binding => Main.runtests.T23, :path => \"/home/runner/work/AutoHashEquals.jl/AutoHashEquals.jl/test/runtests.jl\"))\n" == "a comment\n"

@NHDaly
Copy link
Member

NHDaly commented Sep 16, 2024

:) Thanks for the PR, Kristoffer!

@NHDaly
Copy link
Member

NHDaly commented Oct 1, 2024

Okay, I confirmed the nightly tests fail independent of this PR: #53.

So this is good to merge.

@NHDaly NHDaly merged commit 1956b02 into JuliaServices:master Oct 1, 2024
2 of 3 checks passed
@NHDaly
Copy link
Member

NHDaly commented Oct 1, 2024

Registering new version:
1956b02#commitcomment-147443431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants