Skip to content

Refactor options into an internal Config struct #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2024
Merged

Refactor options into an internal Config struct #190

merged 3 commits into from
Oct 7, 2024

Conversation

nickrobinson251
Copy link
Collaborator

@nickrobinson251 nickrobinson251 commented Sep 25, 2024 •
edited
Loading

close #186

@nickrobinson251 nickrobinson251 marked this pull request as ready for review October 7, 2024 13:17
@nickrobinson251 nickrobinson251 requested a review from Drvi October 7, 2024 13:18
Drvi
Drvi approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@Drvi Drvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@nickrobinson251 nickrobinson251 enabled auto-merge (squash) October 7, 2024 13:28
@nickrobinson251 nickrobinson251 merged commit 79cb313 into main Oct 7, 2024
7 checks passed
@nickrobinson251 nickrobinson251 deleted the npr-config branch October 7, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drvi Drvi Drvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor runtests internals to use a single struct for options
2 participants
@nickrobinson251 @Drvi