Require HTTP.jl v1.10.17 and URIs.jl v1.6, and require Julia 1.6+ #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviks
reviewed
Jun 20, 2025
Project.toml
Outdated
| @@ -13,7 +13,7 @@ SodiumSeal = "2133526b-2bfb-4018-ac12-889fb3908a75" | |||
| URIs = "5c2747f8-b7ea-4ff2-ba2e-563bfd36b1d4" | |||
|
|
|||
| [compat] | |||
| HTTP = "0.9, 1" | |||
| HTTP = "1.10.17" # We need HTTP v1.10.17 in order to get https://github.com/JuliaWeb/HTTP.jl/pull/1225, which in turn gives us https://github.com/JuliaWeb/URIs.jl/pull/66 | |||
There was a problem hiding this comment.
That's a long comment. Maybe this should just be in the PR or commit message?
There was a problem hiding this comment.
I wanted to make sure that someone didn't unknowingly lower the compat bound later.
How about something like this:
# Do not remove, see https://github.com/JuliaWeb/GitHub.jl/pull/225There was a problem hiding this comment.
Or this:
# Must be >= 1.10.17, see https://github.com/JuliaWeb/GitHub.jl/pull/225There was a problem hiding this comment.
I've shortened the comment.
DilumAluthge
commented
Jun 20, 2025
DilumAluthge
changed the title
DilumAluthge
changed the title
|
Tests had failed with julia 1.0, since the latest version of URI.jl only supports 1.6+. I've updated the julia compat of this package. |
aviks
approved these changes
Jun 21, 2025
DilumAluthge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need HTTP v1.10.17 in order to get JuliaWeb/HTTP.jl#1225, which in turn gives us JuliaWeb/URIs.jl#66.
And we need URIs v1.6 in order to get JuliaWeb/URIs.jl#66.