Fix accidental method name rename and support disabling underline #19
Conversation
src/VT100.jl
Outdated
| @@ -167,7 +167,7 @@ end | |||
| Base.size(s::ScreenEmulator) = (s.ViewPortSize.height, s.ViewPortSize.width) | |||
| create_cell(em::ScreenEmulator,c::Char) = Cell(em.cur_cell, content = c) | |||
| cur_cell(em::ScreenEmulator) = em.cur_cell | |||
| set_cur_cell!(em::ScreenEmulator,c::Cell) = em.cur_cell = c | |||
| set_cur_cell(em::ScreenEmulator,c::Cell) = em.cur_cell = c | |||
There was a problem hiding this comment.
It really should have a !. Can we keep both?
There was a problem hiding this comment.
It is currently inconsistent with
Line 240 in 07d02ef
and nothing is using the ! version right now. I can switch everything to !.
There was a problem hiding this comment.
Let's switch everything to !. If necessary, we can keep the non-! version for compatibility.
There was a problem hiding this comment.
Also, I guess we lost CI or it would have caught this. Could you update the CI with whatever the current way we test packages is (github actions I guess?)
There was a problem hiding this comment.
Made ! be used consistently and added CI. It is not showing up though, maybe you have to approve it first time?
There was a problem hiding this comment.
I think it needs to be on master first for it to know to turn it on. I'll merge and see what happens.
KristofferC
force-pushed
the
kc/fixes
branch
from
f16392b to
e36f714
Compare
267de5c#diff-4fe25bb028b611515bcc568694f6375e318be1d15ad7028e48c40aef15acee64R170