Skip to content

Remove SPV_INTEL_fast_composite extension #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Remove SPV_INTEL_fast_composite extension #3183

merged 1 commit into from
Jun 10, 2025

Conversation

vsemenov368
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 20, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MrSidims
Copy link
Contributor

Thanks! @vsemenov368 was this extension used before in product? If yes - lets follow https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/main/README.md#deprecation-of-preview-extensions , see #3025 and #3130 as examples. Otherwise already generated modules with the extension won't be consumed by the translator resulting in an error in a device driver.

@MrSidims MrSidims changed the title Remove Fast Composite extension Remove SPV_INTEL_fast_composite extension May 23, 2025
@MrSidims MrSidims merged commit e23610c into KhronosGroup:main Jun 10, 2025
9 checks passed
@vsemenov368
Copy link
Contributor Author

/backport llvm_release_200

@github-actions GitHub Actions
Copy link

Attempting to create backport to llvm_release_200...

github-actions bot pushed a commit that referenced this pull request Jun 10, 2025
@vsemenov368
Remove SPV_INTEL_fast_composite extension (#3183)
8651a21
@github-actions GitHub Actions
Copy link

Success. Backport PR created: #3223

@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Merged
@vsemenov368
Copy link
Contributor Author

/backport llvm_release_190

@github-actions GitHub Actions
Copy link

Attempting to create backport to llvm_release_190...

github-actions bot pushed a commit that referenced this pull request Jun 10, 2025
@vsemenov368
Remove SPV_INTEL_fast_composite extension (#3183)
a41546a
@github-actions GitHub Actions
Copy link

Success. Backport PR created: #3224

@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Merged
@vsemenov368
Copy link
Contributor Author

/backport llvm_release_180

@github-actions GitHub Actions
Copy link

Attempting to create backport to llvm_release_180...

@github-actions GitHub Actions
Copy link

Backport to llvm_release_180 failed due to conflicts on commit e23610c8a9e953339b7dfd11d1b95e3db34c7d50. Please backport manually.

MrSidims pushed a commit that referenced this pull request Jun 12, 2025
@github-actions @vsemenov368
[Backport to llvm_release_200] Remove SPV_INTEL_fast_composite extens…
74843f2 
…ion (#3223)

Backport of PR #3183 into `llvm_release_200`.

All commits applied cleanly.

Co-authored-by: Vadim Semenov <[email protected]>
MrSidims pushed a commit that referenced this pull request Jun 12, 2025
@github-actions @vsemenov368
[Backport to llvm_release_190] Remove SPV_INTEL_fast_composite extens…
6a96a62 
…ion (#3224)

Backport of PR #3183 into `llvm_release_190`.

All commits applied cleanly.

Co-authored-by: Vadim Semenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSidims MrSidims MrSidims approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsemenov368 @CLAassistant @MrSidims