spirv-opt: Add a folding rule for OpBitReverse.
#6321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-perron
reviewed
Sep 12, 2025
Collaborator
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
The implementation looks good, but it could use more tests. Just to have a little more coverage in case someone decides to change it.
luciechoi
changed the title
OpBitReverse.OpBitReverse.
Collaborator
Author
Thank you, I added more test cases and modified the folding logic to handle null constants |
s-perron
reviewed
Sep 15, 2025
luciechoi
force-pushed
the
reversebit
branch
from
bcc5fa2 to
d6c3793
Compare
s-perron
reviewed
Sep 17, 2025
luciechoi
force-pushed
the
reversebit
branch
from
80ba27d to
763fa08
Compare
s-perron
approved these changes
Sep 23, 2025
Collaborator
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
I think this look good now. You can merge when you think it is ready.
Collaborator
Author
|
Thank you for the thorough review, will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a folding rule for
OpBitReverseon scalar and vector types.Noticed we are missing this optimization while working on microsoft/DirectXShaderCompiler#7680
Additionally, fix various constant folding errors for
OpBitCastto handle null constants as well as lower-bit to higher-bit integer conversions. Previously, it was throwing error for e.g.OpBitcast %int %v2ushort_1_null.