Conversation
djones6
suggested changes
May 14, 2019
Contributor
djones6
left a comment
djones6
left a comment
There was a problem hiding this comment.
Let's add support for PS512 too, so that we support all of the algorithms listed on jwt.io
And if you think it's appropriate, add a doc comment regarding the minimum key size.
Contributor
|
Also your tests are failing on MacOS with Swift 4.0.3: This may be because the xcode image is too old (xcode9.2 seems to give you MacOS 10.12.6) |
djones6
reviewed
May 14, 2019
Andrew-Lees11
changed the title
Contributor
Author
|
I have updated our RSA key to be 2048 bit so that it can be used for ps512. I have also added if available calls to our tests since RSA-PSS requires MacOS 10.13. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds two now signers and verifiers for the PS256 and PS384 JWT algorithms.
These use the new RSA-PSS support introduced in BlueRSA 1.0.31.
Tests have been added for sign -> verify cycle and against the JWT.io implementation by using a JWT they generated and generating a JWT that is then verfied on JWT.io.
This adds the functionality requested by issue #55.