feat: Ignore newlines in key generation and allow DER formatting#68
Merged
ianpartridge merged 4 commits intomasterfrom Jul 16, 2019
Merged
feat: Ignore newlines in key generation and allow DER formatting#68ianpartridge merged 4 commits intomasterfrom
ianpartridge merged 4 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is intended to address issue #51 where the rsa key creation appears to be failing due to poor formatting.
Inside BlueRSA, the PEM headers are stripped by splitting on new line characters and removing the lines with the PEM header string (e.g -----BEGIN PRIVATE KEY-----). This causes the generation to fail if the headers are not on there own line (e.g. Google seems to create the key with headers and body on a single line)
This PR removes all whitespace and checks for the header dashes (-----) in the same was as BlueECC so that whitespace doesn't change the ability to process they key. The BlueRSA key is then created from the resulting DER data.
Since we are now initializing from DER data I allowed that to be passed in to the public key initializer without failing and have added a test to cover this behavior.