Skip to content

Conversation

@Kludex
Copy link
Owner

@Kludex Kludex commented Jun 4, 2023

@Kludex Kludex marked this pull request as draft June 4, 2023 10:39
@Kludex Kludex marked this pull request as ready for review June 6, 2023 06:53
@Kludex Kludex requested a review from a team June 6, 2023 06:53
- [ ] I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
- [ ] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
- [ ] I've updated the documentation accordingly.
- [ ] I've added a note on the `docs/release-notes.md` about my changes (changes on documentation or type annotations don't need this).
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm removing this here since I noticed this will be a problem on future PRs, since we have a script that checks the version on __init__.py against the first version found on the release notes.

@Kludex Kludex enabled auto-merge (squash) June 7, 2023 06:24
@Kludex Kludex merged commit da7adf2 into master Jun 7, 2023
@Kludex Kludex deleted the release/0.28.0 branch June 7, 2023 06:25
adriangb pushed a commit to adriangb/starlette that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants