Adding support for different types for spec and push consts#242
Merged
Adding support for different types for spec and push consts#242
Conversation
bab3cf2 to
646fe61
Compare
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
3344c0a to
84a8ed5
Compare
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
84a8ed5 to
9326200
Compare
Signed-off-by: Alejandro Saucedo <axsauze@gmail.com>
ba1e1f6 to
c758ec0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Adds support for different types. For Push consts it is possible to add custom structs.
This means that constants can be defined as:
but they can also be defined as array, as follows:
By default it is possible to continue just using float, without template definition:
std::shared_ptr<kp::Algorithm> algo = mgr.algorithm(..., {0.1f, 0.2f, 0.3f});Full example below:
Python interface
The python interface is exposed as follows: