-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Spike: Pre-bundle certain plugins for Insomnia and Inso #8813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: spike/support-vault-plugin
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really cool, well done!
I think theres some room to simplify the bundle-plugins.ts scripts but just a nitpick.
We could also consider just stacking the script before the build step rather than using the beforePack argument of electron-builder. Might help with simplification too.
Good catch, Move the bundle script to npm build script instead of beforePack hook |
if (require.main === module) { | ||
process.nextTick(async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now this isn't in the beforePack function you shouldn't need this code.
POC to pre-bundle certain plugins for Insomnia and Inso production build.