Skip to content

Spike: Pre-bundle certain plugins for Insomnia and Inso #8813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: spike/support-vault-plugin
Choose a base branch
from

Conversation

cwangsmv
Copy link
Contributor

POC to pre-bundle certain plugins for Insomnia and Inso production build.

@cwangsmv cwangsmv marked this pull request as draft June 23, 2025 07:32
Copy link
Contributor

@jackkav jackkav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really cool, well done!
I think theres some room to simplify the bundle-plugins.ts scripts but just a nitpick.
We could also consider just stacking the script before the build step rather than using the beforePack argument of electron-builder. Might help with simplification too.

@cwangsmv
Copy link
Contributor Author

Looks really cool, well done! I think theres some room to simplify the bundle-plugins.ts scripts but just a nitpick. We could also consider just stacking the script before the build step rather than using the beforePack argument of electron-builder. Might help with simplification too.

Good catch, Move the bundle script to npm build script instead of beforePack hook

Comment on lines +10 to +11
if (require.main === module) {
process.nextTick(async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now this isn't in the beforePack function you shouldn't need this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants