WIP: status for cluster and syncregistry #831
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinjiaKarl
requested review from
elliotxx,
panshuai111,
adohe,
ffforest and
ruquanzhao
as code owners
jinjiaKarl
commented
Apr 4, 2025
| clusterCreated, err := client.DynamicClient.Resource(clusterGVR). | ||
| Create(ctx, unstructuredCluster, metav1.CreateOptions{}) | ||
|
|
||
| // Question: when use clusterapi.ClusterStatus, when use clusterv1beta1.ClusterStatus? |
There was a problem hiding this comment.
I am kinda new to developing acustom apiserver and controller. Since there are internal api types and external (v1beta1) api types, can I ask which one to use in which situation?
In the syncer reconcile, it is all v1beta1 api types.
There was a problem hiding this comment.
Hi! Karpor has two important features. One is resource insight and another is the proxy.
The api types in v1beta1 directory define the crd of special version (v1beta1), and we use it in syncing resource and insighting. The internal api types (such as pkg/kubernetes/apis/cluster/types.go) are used to proxy.
There was a problem hiding this comment.
Thanks for explaining!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
TODO
Which issue(s) this PR fixes:
Fixes #818