Skip to content

Incorrect buffer size check in meshopt_spatialSortRemap function #981

@HamiltonHuaji

Description

@HamiltonHuaji

Version

3.3.4 (snapshot)

Platform

Linux x64, Linux arm64, Linux arm32, macOS x64, macOS arm64, Windows x64, Windows x86, Windows arm64

JDK

Not Applicable

Module

Meshopt

Bug description

The meshopt_spatialSortRemap function, as well as potentially other functions in the meshopt module of the lwjgl library has an incorrect buffer size check.
According to the documentation, the destination buffer is expected to have enough space. However, the implementation calculates the vertex_count variable based on the remaining space in the destination buffer and checks the remaining space of vertex_positions buffer.
The correct implementation should calculate vertex_count based on vertex_positions.remaining() and check the remaining space of the destination buffer.

Stacktrace or crash log output

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions