Skip to content

Adding UvA-DL notebook "Inception, ResNet, and DenseNet" #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 2, 2021

Conversation

phlippe
Copy link
Contributor

@phlippe phlippe commented Aug 27, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
    => Discussed on Slack channel
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This PR adds a new tutorial of the UvA Deep Learning course, this time on Inception, ResNet and DenseNet. The tutorial is an adapted version of the original tutorial for the Deep Learning course at the University of Amsterdam (link).

The png and svg files are images that are included in the notebook.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from Borda August 27, 2021 16:22
@phlippe phlippe marked this pull request as ready for review August 27, 2021 16:26
@Borda Borda added the Example Example / Demo / Tutorial label Aug 27, 2021
@Borda Borda self-assigned this Aug 27, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is Awsome!


# %%
# Github URL where saved models are stored for this tutorial
base_url = "https://raw.githubusercontent.com/phlippe/saved_models/main/tutorial5/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think it would make sense to have kind of releases with Tutorials and upload these models to the release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be a bad idea. The separate GitHub repo is more of a quick hack than a long-term solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, mind open an issue for it and I ll have look at it later... just to not forget it :]

# %tensorboard --logdir ../saved_models/tutorial5/tensorboards/GoogleNet/

# %% [markdown]
# <center width="100%"><img src="tensorboard_screenshot_GoogleNet.png" width="1000px"></center>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as MD?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will try to write a small script that replaces the HTML expressions for png images with MD syntax.

@Borda Borda added the 0:] Ready->Go ready to go/merge label Aug 31, 2021
@Borda Borda force-pushed the inception-resnet-densenet branch from 6cda4bf to 3e8c8f4 Compare August 31, 2021 11:01
@Borda Borda enabled auto-merge (squash) September 2, 2021 15:29
@Borda Borda merged commit 86f8858 into Lightning-AI:main Sep 2, 2021
@phlippe phlippe mentioned this pull request Sep 2, 2021
@phlippe phlippe deleted the inception-resnet-densenet branch December 4, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0:] Ready->Go ready to go/merge Example Example / Demo / Tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants