-
Notifications
You must be signed in to change notification settings - Fork 11
Cyclomatic complexity #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e preprocessing on Flow Model(description, apiversion, etc)
Eeeey as always this is good! My stuff is a WIP, this actually follows the McCabe counting system. Mine was more like the number of paths you can take towards the end 😂 |
@junners One reason I have not proceeded with this rule is that I am unsure on what the default threshold should be. From my experience a lot of organizations are currently dealing with high cyclomatic complexity in Flows and I think we should start with a rather leniant threshold. Although it is fully configurable, I am very keen to learn what your opinion is on what could be an acceptable threshold |
My rollout plan was to atleast make it a note level, then via sfdx/vsce collect usage stats. We won't fully know until we actually get some data |
Just logged in to my personal machine. I'm looking at this rn |
Kk i've fixed some of the changes 👍🏻 I'll add in some unit tests on cyclomatic complexity |
Edit: Let's release this as note |
I'll do a release in the next couple of days~ |
This PR includes a new rule and some minor adjustments to the Flow Model, allowing for some simple metadata type preprocessing(Counting loops etc)
Todo