Merged
Conversation
Closed
mshenfield
reviewed
Dec 1, 2017
| 'tip directive': | ||
| 'prefix': 'tip' | ||
| 'body': '.. tip::\n\n\t' | ||
| 'topic directive': |
There was a problem hiding this comment.
Would you consider adding this snippet for the toctree directive
'toctree directive':
'prefix': 'toctree'
'body': '.. toctree::\n\t:maxdepth: ${1:2}\n\n\t$0'
Alhadis
requested changes
Dec 1, 2017
Collaborator
Alhadis
left a comment
Alhadis
left a comment
There was a problem hiding this comment.
Looks great! 😀 If you could fix what I pointed out and add the toctree snippet, I'll get this merged.
| 'body': '.. compound::\n\n\t' | ||
| 'container directive': | ||
| 'prefix': 'container' | ||
| 'body': '.. container:: {$1:class}\n\n\t$0' |
Collaborator
There was a problem hiding this comment.
Typo on this line. 😉 It should be ${, not {$.
| 'body': '.. tip::\n\n\t' | ||
| 'topic directive': | ||
| 'prefix': 'topic' | ||
| 'body': '.. topic## $1{1:title}' |
Collaborator
There was a problem hiding this comment.
Typo on this line too: $1{1 should simply be ${1
| 'body': ':ref:`$0`' | ||
| 'menuselection role': | ||
| 'prefix': 'menuselection' | ||
| 'body': ':menuselection:`${1:menu item} --> {$2:submenu item}`' |
| 'tip directive': | ||
| 'prefix': 'tip' | ||
| 'body': '.. tip::\n\n\t' | ||
| 'topic directive': |
Fixed several typos. Added : - toctree directive - plot directive (matplotlib) - bokeh-plot directive (bokeh)
Contributor
Author
|
Done. Thanks for the review. |
Alhadis
approved these changes
Dec 1, 2017
Collaborator
|
Thanks! I'll strive to get a release cut as soon as possible, which is easier said than done since my MacBook died the other night, and I'm currently Atom-less...😣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.