Cli importer csv #283
Open
Cli importer csv #283
+14,415
−13,270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
example.zip |
cheburan
force-pushed
the
cli_importer_CSV
branch
from
2242d09 to
35c5f44
Compare
… convertion to JSON, (via API request)
cheburan
force-pushed
the
cli_importer_CSV
branch
from
35c5f44 to
a5ff835
Compare
lukashroch
reviewed
Oct 1, 2024
| @@ -156,6 +157,14 @@ function adminCategoryController({ | |||
| res.json(categories); | |||
| }; | |||
|
|
|||
| const all = async ( | |||
There was a problem hiding this comment.
This might quickly become a perf hog and cause issues for larger sets, better use paginated query/response?
There was a problem hiding this comment.
Please correct me if I'm wrong, but it looks like this isn't being used anywhere. Also, it looks like browseMain already implements what this intends to do but with pagination. Should it be removed?
There was a problem hiding this comment.
I haven't checked the whole PR, just noticed it's there, but we should definitely delete it if it's a dead code. It's a bit muddle with merge commits, so probably best to rebase on main / clean-up of dead code and put into main.
lukashroch
force-pushed
the
main
branch
3 times, most recently
from
a76af83 to
bba98c5
Compare
…efactoring and fixes The script now also generates a local-categories.json. Fixed a few typos. Added additional logs. Added trim() since to account for accidental whitespaces. Replaced some for...of loops with Promise.all.
…t wanted by locale Replace more for...of loops with promise.all so they can run in parallel. When creating local foods, exclude foods that are not wanted by the locale.
Previously, the associated foods/categories were incomplete. Associated categories codes were considered as food code even though they are not. Now, it correctly searches the database to identify whether it is a food code or category code.
Use short circuiting; Replace array includes with set has for linear time complexity; Add more error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the converting tool to the CLI for the food-table CSV conversion to the package format.