Introduce AP to control IsTabStop of the reveal button in PasswordBox (reveal style) #3800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3799
As mentioned in the issue/feature request, I have been unsuccessful at trying to fix this by simply overriding a style (in particular the
MaterialDesignRawToggleButtonstyle). I believe this has become somewhat more difficult after we decided to move the "internal styles" out of the root-levelResourceDictionaryand closer to where they are used.In this particular case, the style is nested under the
<ControlTemplate.Resources>and thus I am unsure how I can override that as a MDIX consumer without overriding the entire template. I did try to move the inner style one level out so it resides in the<Style.Resources>instead; however even with that in place, I still struggled to override it.This PR introduces an AP which allows the caller to control it.
I added a UI test mainly for the purpose of playing around with various ways of getting it to work, but in the end I could only get the AP approach to work 😞
Without AP
With AP (set to
False)