fix(#93): Use Gradle's default output folder in gradle projects

[notusedusername]

Applied the mitigation that appeared for Gradle after the subdirectory handling for the subdirectories too.

This is just a proposal, as it is a bit error-prone to have the input value and the step output value too for the javadoc-source-folder variable, it can be easily missed which one should be used in future development.

close #95
close #93

[MathieuSoysal]

Hi notusedusername,

Thank you for your contribution 🎉 and the proposed fix for using Gradle's default output folder in Gradle projects. We appreciate your effort in addressing the subdirectory handling.

Before we proceed, could you please confirm if you have tested the changes? It would be helpful to know if the modifications were verified in different scenarios to ensure they work as expected.

Thank you again for your contribution! 🥳

[notusedusername]

Hi @MathieuSoysal,

it's still under testing as I didn't really have the time to do that properly on Friday. I put this PR to draft until it's done, sorry that I missed that before.

[notusedusername]

@MathieuSoysal I tested the changes, and it's looking good to me.

[notusedusername]

Uh, these test results look pretty bad 😢 . As I saw all of the Gradle cases passed, only the Maven-related cases failed, but all of them.

I dug around the issue a bit, and it seems like the default javadoc generation path has been changed in theorg.apache.maven.plugins:maven-javadoc-plugin from target/site/apidocs to target/reports/apidocs.

As the action generates the docs into the plugin's default directory, and then uses the hardcoded (and it seems outdated) default path to aggregate/copy them, it won't work with newer plugin versions.

I couldn't find the exact mention of this change in the release notes, but locally I used 3.5.0 and it worked like charm.
If I upgrade it to 3.11.2 (the latest and also the version used by the tests), then it'll generate to the new path (and fail).

Meanwhile, as I was writing this lorem ipsum, I figured that these tests have been failing for months, so they are definitely not regression.

@MathieuSoysal ☝️

[MathieuSoysal]

@notusedusername I have implemented the fix for issue #95. Could you please grant me permission to commit to your repository/branch ?

[MathieuSoysal]

Hi @notusedusername,

I have pushed the latest fix, but there is still one test that is failing. Do you have any suggestions on how to resolve it?

Thank you!

[MathieuSoysal]

Perfect ! Thank you a lot for your contribution 🥳