Skip to content

Release/430.0.0 #5935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

Release/430.0.0 #5935

merged 2 commits into from
Jun 6, 2025
+198 −132

Conversation

nickewansmith
Copy link
Contributor

Explanation

Release core v 430.0.0

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@nickewansmith nickewansmith marked this pull request as ready for review June 6, 2025 14:00
@nickewansmith nickewansmith requested review from a team as code owners June 6, 2025 14:00
cryptodev-2s
cryptodev-2s previously requested changes Jun 6, 2025
View reviewed changes
@nickewansmith
Copy link
Contributor Author

@cryptodev-2s I don't understand why these other packages are receiving this version change that I don't expect. I would expect other packages to continue with the version they were using before. Will discuss with you in slack

cryptodev-2s
cryptodev-2s reviewed Jun 6, 2025
View reviewed changes
@nickewansmith nickewansmith force-pushed the release/430.0.0 branch 5 times, most recently from 15a636f to 1419a91 Compare June 6, 2025 20:11
Matt561
Matt561 previously approved these changes Jun 6, 2025
View reviewed changes
mcmire
mcmire reviewed Jun 6, 2025
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing but otherwise good to go!

@nickewansmith nickewansmith force-pushed the release/430.0.0 branch 2 times, most recently from e6c5370 to aaefe12 Compare June 6, 2025 20:35
@nickewansmith nickewansmith requested a review from mcmire June 6, 2025 20:36
@mcmire mcmire dismissed cryptodev-2s’s stale review June 6, 2025 20:36

All requested changes seem to be addressed.

mcmire
mcmire reviewed Jun 6, 2025
View reviewed changes
packages/logging-controller/CHANGELOG.md Outdated
Comment on lines 10 to 14
### Changed

- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))

### Changed

- Bump `@metamask/base-controller` from ^8.0.0 to ^8.0.1 ([#5722](https://github.com/MetaMask/core/pull/5722))
- Bump `@metamask/controller-utils` to `^11.9.0` ([#5583](https://github.com/MetaMask/core/pull/5583), [#5765](https://github.com/MetaMask/core/pull/5765), [#5812](https://github.com/MetaMask/core/pull/5812))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you can merge these:

Suggested change
### Changed
- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
### Changed
- Bump `@metamask/base-controller` from ^8.0.0 to ^8.0.1 ([#5722](https://github.com/MetaMask/core/pull/5722))
- Bump `@metamask/controller-utils` to `^11.9.0` ([#5583](https://github.com/MetaMask/core/pull/5583), [#5765](https://github.com/MetaMask/core/pull/5765), [#5812](https://github.com/MetaMask/core/pull/5812))
### Changed
- Bump `@metamask/base-controller` from ^8.0.0 to ^8.0.1 ([#5722](https://github.com/MetaMask/core/pull/5722))
- Bump `@metamask/controller-utils` to `^11.10.0` ([#5583](https://github.com/MetaMask/core/pull/5583), [#5765](https://github.com/MetaMask/core/pull/5765), [#5812](https://github.com/MetaMask/core/pull/5812), [#5935](https://github.com/MetaMask/core/pull/5935))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let me see if the lint passes as yarn changelog:validate is not catching the same errors ci seems to be. I'll make this change shortly

cryptodev-2s
cryptodev-2s reviewed Jun 6, 2025
View reviewed changes
packages/chain-agnostic-permission/CHANGELOG.md Outdated
Comment on lines 13 to 14
- Bump `@metamask/network-controller` to `^23.6.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
- Bump `@metamask/network-controller` to `^23.5.1` ([#5882](https://github.com/MetaMask/core/pull/5882))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge these two ?

cryptodev-2s
cryptodev-2s reviewed Jun 6, 2025
View reviewed changes
packages/eip1193-permission-middleware/CHANGELOG.md Outdated
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
- Bump `@metamask/chain-agnostic-permission` to `^0.7.0` ([#5518](https://github.com/MetaMask/core/pull/5518), [#5674](https://github.com/MetaMask/core/pull/5674), [#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583))
- Bump `@metamask/controller-utils` to `^11.9.0` ([#5583](https://github.com/MetaMask/core/pull/5583), [#5765](https://github.com/MetaMask/core/pull/5765), [#5812](https://github.com/MetaMask/core/pull/5812))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge both controller utils under this Changed Section

packages/ens-controller/CHANGELOG.md Outdated
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge both controller utils under the Changed Section

packages/gas-fee-controller/CHANGELOG.md Outdated
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge this with the below controller-utils bump while keeping one Changed Section

packages/logging-controller/CHANGELOG.md Outdated
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps in this section?

packages/message-manager/CHANGELOG.md Outdated
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps while keeping one Changed section

packages/permission-controller/CHANGELOG.md Outdated
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps while keeping one Changed Section

packages/phishing-controller/CHANGELOG.md Outdated
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps while keeping one Changed Section

packages/polling-controller/CHANGELOG.md Outdated
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps while keeping one Changed Section

packages/queued-request-controller/CHANGELOG.md Outdated
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps while keeping one Changed Section

packages/remote-feature-flag-controller/CHANGELOG.md Outdated
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Bump `@metamask/controller-utils` to `^11.10.0` ([#5935](https://github.com/MetaMask/core/pull/5935))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge both controller-utils bumps while keeping one Changed Section

@nickewansmith
Copy link
Contributor Author

Thank you two for the review, I just realized I was misusing the validation script and so I thought it was passing for me locally, but alas, it was not. I understand what I was doing wrong now!

@nickewansmith
Copy link
Contributor Author

@mcmire @cryptodev-2s I think it should be gtg this time 🤞🏽

cryptodev-2s
cryptodev-2s approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nickewansmith nickewansmith merged commit 3cd5946 into main Jun 6, 2025
220 checks passed
@nickewansmith nickewansmith deleted the release/430.0.0 branch June 6, 2025 21:16
@mcmire mcmire mentioned this pull request Jun 13, 2025
Merged
4 tasks
@adonesky1 adonesky1 mentioned this pull request Jun 13, 2025
Merged
adonesky1 added a commit that referenced this pull request Jun 13, 2025
@adonesky1
Release/439.0.0 (#5982)
1a19d0e 
## @metamask/chain-agnostic-permission

## [0.7.1]

### Changed

- Bump `@metamask/keyring-internal-api` to `^6.2.0`
([#5871](#5871))
- Bump `@metamask/controller-utils` to `^11.10.0`
([#5935](#5935))
- Bump `@metamask/network-controller` to `^23.6.0`
([#5935](https://github.com/MetaMask/core/pull/5935),[#5882](https://github.com/MetaMask/core/pull/5882))
- Change `caip25CaveatBuilder` to list unsupported scopes in the
unsupported scopes error
([#5806](#5806))
### Fixed
- Fix `isInternalAccountInPermittedAccountIds` and
`isCaipAccountIdInPermittedAccountIds` to correctly handle comparison
against `permittedAccounts` values of the `wallet:<namespace>:<address>`
format ([#5980](#5980))
@adonesky1 adonesky1 mentioned this pull request Jun 20, 2025
Merged
adonesky1 added a commit that referenced this pull request Jun 20, 2025
@adonesky1
Release/447.0.0 (#6013)
b9d7622 
## @metamask/chain-agnostic-permission

## [1.0.0]

### Changed

- This package is now considered stable

## @metamask/eip1193-permission-middleware

## [1.0.0]

### Changed

- Bump `@metamask/chain-agnostic-permission` to `^0.8.0`
([#5518](#5518),
[#5674](#5674),
[#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583),
[#5982](https://github.com/MetaMask/core/pull/5982),[#6004](https://github.com/MetaMask/core/pull/6004))
- Bump `@metamask/chain-agnostic-permission` to `^0.8.0`
([#5550](#5550),
[#5518](#5518),
[#5674](#5674),
[#5715](#5715),
[#5760](#5760),
[#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583),
[#5982](https://github.com/MetaMask/core/pull/5982),[#6004](https://github.com/MetaMask/core/pull/6004))
- Bump `@metamask/controller-utils` to `^11.10.0`
([#5935](#5935),
[#5583](#5583),
[#5765](#5765),
[#5812](#5812))


## @metamask/multichain-api-middleware

## [1.0.0]

### Changed

- Bump `@metamask/chain-agnostic-permission` to `^0.8.0`
([#5518](#5518),
[#5674](#5674),
[#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583),
[#5982](https://github.com/MetaMask/core/pull/5982),[#6004](https://github.com/MetaMask/core/pull/6004))
- Bump `@metamask/chain-agnostic-permission` to `^0.8.0`
([#5550](#5550),
[#5518](#5518),
[#5674](#5674),
[#5715](#5715),
[#5760](#5760),
[#5818](https://github.com/MetaMask/core/pull/5818)[#5583](https://github.com/MetaMask/core/pull/5583),
[#5982](https://github.com/MetaMask/core/pull/5982),[#6004](https://github.com/MetaMask/core/pull/6004))
- Bump `@metamask/controller-utils` to `^11.10.0`
([#5935](#5935),
[#5583](#5583),
[#5765](#5765),
[#5812](#5812))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@Matt561 Matt561 Matt561 left review comments

@mcmire mcmire Awaiting requested review from mcmire

Assignees
No one assigned
Labels
no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickewansmith @mcmire @Matt561 @cryptodev-2s