feat: Modify the volume of the music #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sound 类的更新后的类图classDiagram
class Sound {
-float musicVolume$
+PlayPrefix(SoundManager.AcbID acbID, SoundManager.PlayerID playerID, int cueID, bool prepare, int target, int startTime, ref float volume) void$
}
note for Sound "Sound 类是静态的。"
文件级别更改
提示和命令与 Sourcery 互动
自定义您的体验访问您的 仪表板 以：
获得帮助Original review guide in EnglishReviewer's GuideIntroduces a configurable musicVolume setting via ConfigEntry and applies it in a Harmony prefix on SoundManager.Play to override the in-game music volume, alongside a minor import reordering. Sequence Diagram for Music Volume Adjustment via Harmony PatchsequenceDiagram
participant EC as ExternalCaller
participant P as Sound.PlayPrefix
participant SM as SoundManager
EC->>SM: Play(acbID=Music, playerID=Music, ..., volume)
activate SM
SM->>P: PlayPrefix(acbID, playerID, ..., ref volume)
activate P
alt acbID == SoundManager.AcbID.Music && playerID == SoundManager.PlayerID.Music
P-->>P: volume = musicVolume (newly configured value)
end
P-->>SM: return (volume parameter is updated)
deactivate P
SM-->>SM: Original Play method executes with (potentially) modified volume
SM-->>EC: (Music plays with new volume)
deactivate SM
Updated Class Diagram for the Sound ClassclassDiagram
class Sound {
-float musicVolume$
+PlayPrefix(SoundManager.AcbID acbID, SoundManager.PlayerID playerID, int cueID, bool prepare, int target, int startTime, ref float volume) void$
}
note for Sound "The Sound class is static."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
嘿 @wuyu8512 - 我已经查看了你的更改，它们看起来很棒！
以下是我在审查期间查看的内容
- 🟡 一般问题：发现 1 个问题
- 🟢 安全性：一切看起来都很好
- 🟢 测试：一切看起来都很好
- 🟢 复杂性：一切看起来都很好
- 🟢 文档：一切看起来都很好
帮助我变得更有用！请点击每个评论上的👍或👎，我将使用反馈来改进你的评论。
Original comment in English
Hey @wuyu8512 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+78
to
+83
| { | ||
| if (acbID == SoundManager.AcbID.Music && playerID == SoundManager.PlayerID.Music) | ||
| { | ||
| volume = musicVolume; | ||
| } | ||
| } |
There was a problem hiding this comment.
建议： 覆盖音量可能会忽略游戏基础音量
考虑将当前音量按 musicVolume 缩放（例如，volume *= musicVolume），以保留其他音量调整。
Suggested change
| { | |
| if (acbID == SoundManager.AcbID.Music && playerID == SoundManager.PlayerID.Music) | |
| { | |
| volume = musicVolume; | |
| } | |
| } | |
| { | |
| if (acbID == SoundManager.AcbID.Music && playerID == SoundManager.PlayerID.Music) | |
| { | |
| volume *= musicVolume; | |
| } | |
| } |
Original comment in English
suggestion: Override volume may ignore base game volume
Consider scaling the current volume by musicVolume (e.g., volume *= musicVolume) to preserve other volume adjustments.
Suggested change
| { | |
| if (acbID == SoundManager.AcbID.Music && playerID == SoundManager.PlayerID.Music) | |
| { | |
| volume = musicVolume; | |
| } | |
| } | |
| { | |
| if (acbID == SoundManager.AcbID.Music && playerID == SoundManager.PlayerID.Music) | |
| { | |
| volume *= musicVolume; | |
| } | |
| } |
|
@clansty 这个不考虑合一下吗，对我来说游戏的正解音即使调到最大还是嫌小，此PR可以让用户调整游戏BGM的音量大小，变相放大正解音 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
好的，这是翻译成中文的 pull request 总结：
Sourcery 总结
添加了自定义音乐音量控制的支持，通过引入一个新的配置项并通过 Harmony 前缀补丁应用于音乐播放来实现。
新特性：
musicVolume配置项以调整背景音乐音量。增强功能：
SoundManager.Play以使用配置的musicVolume覆盖音乐提示音量。Original summary in English
Summary by Sourcery
Add support for custom music volume control by introducing a new configuration entry and applying it via a Harmony prefix patch on music playback.
New Features:
musicVolumeconfig entry to adjust background music volume.Enhancements:
SoundManager.Playto override music cue volume using the configuredmusicVolume.