-
Notifications
You must be signed in to change notification settings - Fork 27
feat: FixLocaleIssues #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
审查者指南添加了一个新的 Harmony 补丁类,该类强制所有数字和日期解析/格式化使用日语区域设置,并覆盖 DateTime.Now 以返回东京标准时间 (UTC+9),并为缺少的时区定义提供回退。 文件级别更改
提示和命令与 Sourcery 交互
自定义您的体验访问您的 仪表板 以:
获取帮助Original review guide in EnglishReviewer's GuideAdds a new Harmony patch class that forces all numeric and date parsing/formatting to use the Japanese locale and overrides DateTime.Now to return Tokyo Standard Time (UTC+9), with a fallback for missing timezone definitions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @beer-psi - 我已经查看了你的更改,它们看起来很棒!
这是我在审查期间查看的内容
- 🟡 General issues: 发现了 3 个问题
- 🟢 Security: 一切看起来都很好
- 🟢 Testing: 一切看起来都很好
- 🟡 Complexity: 发现了 1 个问题
- 🟢 Documentation: 一切看起来都很好
帮助我更有用!请点击每个评论上的 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @beer-psi - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
doesn't actually work, thanks AI for nothing
我想问一下,这个 patch 是修复了什么问题,比如说游戏如果不是以日语区域或者以 +9 时区运行会有什么影响呢 |
Patches a few locale-dependent system functions to always use the Japanese locale, which is what the game expects. Also forces
DateTime.Now
to return UTC+9.好的,这是翻译成中文的 pull request 总结:
Sourcery 总结
修复了依赖于区域设置的解析和格式化方法,以始终使用日语区域设置,并强制 DateTime.Now 使用东京(UTC+9)时间。
Bug 修复:
Original summary in English
Summary by Sourcery
Patch locale-dependent parsing and formatting methods to consistently use the Japanese locale and force DateTime.Now to Tokyo (UTC+9) time.
Bug Fixes: