Skip to content

the "flash" program in openOS does not warn that the EEPROM is readonly #3682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
igorkll opened this issue Dec 5, 2023 · 4 comments
Closed

Comments

@igorkll
Copy link

igorkll commented Dec 5, 2023

when trying to flash read only eeprom, the flash program does not display a message stating that the flash failed

ff66theone added a commit to ff66theone/OpenComputers that referenced this issue Apr 27, 2025
Potential fix for MightyPirates#3682, declaration of `eeprom` moved to main chunk.
@ff66theone ff66theone mentioned this issue Apr 27, 2025
@Ocawesome101
Copy link
Contributor

how does one make an eeprom read-only?

@ff66theone
Copy link
Contributor

There is a function called eeprom.makeReadOnly(), but the problem I encountered while making the fix was that I can't query the read-only state of the EEPROM, so I resorted to try changing the label, which, I checked in the source code, fails if the EEPROM is read-only.

@ff66theone
Copy link
Contributor

Uhhhh your fix didn't implement any warning before flashing, so does it really fix this issue ?

@asiekierka
Copy link
Contributor

asiekierka commented Jun 1, 2025

the flash program does not display a message stating that the flash failed

Now it displays a message stating that the flash failed (because eeprom.set() always returned an error message, it was just ignored). Showing a "warning" before makes no difference. On top of that, this approach is future-proof in case OpenComputers adds other ways for flashing to fail (for example, insufficient power can cause an EEPROM flash to fail).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants