Drop "Enum" prefix for enumerations

[kashike]

We're planning to do the following changes to make things consistent, and 1.14 is a good time to do it with the large changes.

Do note that these are only what vanilla names will use - you're free to name your own classes in your mods however you like.

---

Propsed change

• Drop the Enum prefix for enumerations
  • this is a hold over from back before packages were a thing with MCP - we essentially faked packages by grouping class names together with prefixes
  • we don't prefix concrete classes with C, etc

---

Please react with 👍 if you are in favour, and 👎 if you are not in favour.

It it HIGHLY encouraged that you read all responses to this, you can change your vote at any time up until the deadline. Please take this seriously as all results are final after the deadline.

Deadline for feedback and voting is Noon PDT Monday (29/04/2019).

ref #814

[DarkGuardsman]

Does someone have a list of all the Enums so I can check if they conflict with any of my APIs when Enum is removed.

[ChloeDawn]

How would they conflict? They'd be in different classpaths unless you're storing your API classes in the minecraft packages...

[bs2609]

All enums are direct subclasses of the Enum class, and can be found by an appropriately-scoped type hierarchy lookup.

[DarkGuardsman]

Conflict as in imports, so for example if I had a Facing enum that existed in previous code with EnumFacing. Then we dropped Enum it would mean that some classes would two Facing imports. I would like to correct this ahead of the switch.

[Pokechu22]

Ignoring inner classes of the enums, but allowing for enums declared inside another class:

22:55:47     pokechu22 | findallc ^(.+\$)?Enum[^$]+$
22:55:47 MCPBot_Reborn | +++ CLASSES +++
22:55:47 MCPBot_Reborn | bcs$b => net/minecraft/block/Block$EnumOffsetType
22:55:47 MCPBot_Reborn | bzc => net/minecraft/block/material/EnumPushReaction
22:55:47 MCPBot_Reborn | cuw$a => net/minecraft/client/renderer/BlockModelRenderer$EnumNeighborInfo
22:55:47 MCPBot_Reborn | ctw => net/minecraft/client/renderer/EnumFaceDirection
22:55:47 MCPBot_Reborn | ddx$a => net/minecraft/client/renderer/vertex/VertexFormatElement$EnumType
22:55:47 MCPBot_Reborn | ddx$b => net/minecraft/client/renderer/vertex/VertexFormatElement$EnumUsage
22:55:47 MCPBot_Reborn | awf => net/minecraft/enchantment/EnumEnchantmentType
22:55:47 MCPBot_Reborn | afc => net/minecraft/entity/EnumCreatureType
22:55:47 MCPBot_Reborn | aog$b => net/minecraft/entity/player/EntityPlayer$EnumChatVisibility
22:55:47 MCPBot_Reborn | aoh => net/minecraft/entity/player/EnumPlayerModelParts
22:55:47 MCPBot_Reborn | auo => net/minecraft/item/EnumAction
22:55:48 MCPBot_Reborn | asc => net/minecraft/item/EnumDyeColor
22:55:48 MCPBot_Reborn | atq => net/minecraft/item/EnumRarity
22:55:48 MCPBot_Reborn | hx => net/minecraft/network/EnumConnectionState
22:55:48 MCPBot_Reborn | iw => net/minecraft/network/EnumPacketDirection
22:55:48 MCPBot_Reborn | kt$a => net/minecraft/network/play/server/SPacketPlayerPosLook$EnumFlags
22:55:48 MCPBot_Reborn | cfe$b => net/minecraft/scoreboard/Team$EnumVisible
22:55:48 MCPBot_Reborn | bmh => net/minecraft/state/EnumProperty
22:55:48 MCPBot_Reborn | adm => net/minecraft/util/EnumActionResult
22:55:48 MCPBot_Reborn | bgy => net/minecraft/util/EnumBlockRenderType
22:55:48 MCPBot_Reborn | er => net/minecraft/util/EnumDirection8
22:55:48 MCPBot_Reborn | eq => net/minecraft/util/EnumFacing
22:55:48 MCPBot_Reborn | adk => net/minecraft/util/EnumHand
22:55:48 MCPBot_Reborn | aez => net/minecraft/util/EnumHandSide
22:55:48 MCPBot_Reborn | xp => net/minecraft/util/EnumTypeAdapterFactory
22:55:48 MCPBot_Reborn | k$b => net/minecraft/util/Util$EnumOS
22:55:48 MCPBot_Reborn | adi => net/minecraft/world/EnumDifficulty
22:55:48 MCPBot_Reborn | ayi => net/minecraft/world/EnumLightType
22:55:48 MCPBot_Reborn | bmu => net/minecraft/world/border/EnumBorderStatus
22:55:48 MCPBot_Reborn | bnj$a => net/minecraft/world/chunk/Chunk$EnumCreateEntityType

[bs2609]

Of course, as mentioned in #817, not all of those are actually enums (e.g. EnumProperty, EnumTypeAdapterFactory).

[liach]

Will enums be suffixed instead? for example, alibaba suffixes enum classes with Enum suffix to prevent confusion https://github.com/alibaba/Alibaba-Java-Coding-Guidelines#naming-conventions rule 14

[kashike]

No, enums will not be suffixed.

[liach]

As long as enum names won't conflict with concrete class names (like one of the concerns in #816), I support this.