[BUGFIX] Disable tests that are failing due to a bug in the CSS parser #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this is a bug in a 3rd-party library, we should fix it there, and our build should not be red in the meantime. Part of #1129
JakeQZ
approved these changes
Dec 17, 2021
| 'attribute (value match)' => ['[href=https://example.org]'], | ||
| // disabled as this currently breaks due to a bug in the CSS parser | ||
| // @see https://github.com/sabberworm/PHP-CSS-Parser/issues/347 | ||
| // 'attribute (value match)' => ['[href=https://example.org]'], |
There was a problem hiding this comment.
Surprised PHPCS isn't moaning that the comment is mostly code.
This was referenced Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is a bug in a 3rd-party library, we should fix it there, and
our build should not be red in the meantime.
Part of #1129