OS-HPXML v1.7 #132
Merged
OS-HPXML v1.7 #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaguire1
reviewed
Aug 2, 2024
| "vacancy": None, | ||
| "water_heater_operating_mode": None, | ||
| "Vacancy": None, | ||
| "Power Outage": None, |
Collaborator
There was a problem hiding this comment.
I should maybe make an issue/TODO around reading outage values, if we don't already have one. It's something we've done in OCHRE before. It's niche in ResStock but we might want to be able to handle it at some point
jmaguire1
approved these changes
Aug 2, 2024
Collaborator
|
I think once we fix the conflicts we're good to go @mnblonsky |
added 8 commits
August 2, 2024 11:24
This was referenced Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates to accept HPXML files from OS-HPXML v1.7 (and therefore ResStock 3.2). Major changes and fixes:
A few things we haven't addressed yet (and probably won't until accepting OS-HPXML v1.8)
Cathedral ceilings
Reference the issue your PR is fixing
Assign at least 1 reviewer for your PR
Test with run_dwelling.py or other script
Update documentation as appropriate
Update changelog as appropriate