Skip to content

Conversation

@JingWang-CUB
Copy link
Collaborator

@JingWang-CUB JingWang-CUB commented Nov 18, 2024

@JingWang-CUB JingWang-CUB changed the title Code for circuit sharing/pausing Example code for circuit sharing/pausing and smart EV charger Nov 18, 2024
@JingWang-CUB JingWang-CUB marked this pull request as ready for review November 18, 2024 18:36
@JingWang-CUB
Copy link
Collaborator Author

This PR is ready for review, thanks!

Copy link
Collaborator

@mnblonsky mnblonsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few things should be removed to keep this example simple and useful for other users. Ideally we'd limit this to 2-3 cases that can be run without additional data or files. I also think we could rename the file to run_panel_controls.py or something like that.

I'm not sure where the project code should live long term, but it seems like keeping it in OCHRE (either merged or in a stale branch) would not be a good precedent for other projects. Maybe a "OCHRE-examples" repo, that could be public or private?

@mnblonsky
Copy link
Collaborator

No need to run test scripts or update docs/changelog, since this doesn't modify source code.

@mnblonsky mnblonsky mentioned this pull request Nov 22, 2024
18 tasks
@JingWang-CUB
Copy link
Collaborator Author

All required changes have been made. Let me know if you have additional comments. Thanks!

@mnblonsky
Copy link
Collaborator

The changes look great. I made a couple of other changes:

  • Replaced the input files with models from ResStock 2024 that we'll include in a future PR.
  • Added a baseline case and a baseline-ev case
  • Updated the compile function, some things weren't working for me.

@mnblonsky
Copy link
Collaborator

mnblonsky commented Dec 4, 2024

Is this what you're expecting from the results? This is total power for the first day.
image

If you're good with these results, feel free to merge!

@JingWang-CUB
Copy link
Collaborator Author

The results look good to me!

@JingWang-CUB JingWang-CUB merged commit b35f4e8 into dev Dec 4, 2024
@JingWang-CUB JingWang-CUB deleted the circuit_control branch December 4, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants