Skip to content

Conversation

@mnblonsky
Copy link
Collaborator

@mnblonsky mnblonsky commented Oct 17, 2023

Addresses #72

  • Reference the issue your PR is fixing
  • Assign at least 1 reviewer for your PR
  • Test with run_dwelling.py or other script
  • Update documentation as appropriate
  • Update changelog as appropriate

@mnblonsky mnblonsky self-assigned this Oct 17, 2023
@mnblonsky mnblonsky requested a review from jmaguire1 October 17, 2023 22:21
@jmaguire1
Copy link
Collaborator

This would be useful for both limiting input power (AHRI 1380) as well as output capacity (for MPC type applications). Should we allow both? We also need to consider what happens to the backup element (disabled in AHRI 1380) and if you ever ignore the signal for comfort reasons (in the standard when you get x degrees off setpoint you override the schedule).

@mnblonsky mnblonsky changed the base branch from dev to new-controls February 27, 2024 21:59
@mnblonsky mnblonsky marked this pull request as ready for review February 28, 2024 18:40
@mnblonsky
Copy link
Collaborator Author

Addressed parts of #72, but not all. "Capacity" control now allows user to directly set the HVAC capacity, and "Max Capacity Fraction" allows limiting the maximum capacity. But we don't have mass flow rate or supply temp yet.

@mnblonsky
Copy link
Collaborator Author

I'm skipping @jmaguire1's review since we're not merging into dev, and there's some bug fixes related to the new_controls branch that I'd like to fix ASAP. These changes should show up in the new_controls PR once that's done.

@mnblonsky mnblonsky merged commit b144307 into new-controls Feb 28, 2024
@mnblonsky mnblonsky deleted the hvac-capacity-ctrl branch February 28, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants