Updates to spectral utility functions for use in rear irradiance decomposition #576
Conversation
rather than 0 for hourly)
|
@cdeline could you please help us merge this? :) use kempe's charge code |
bifacial_radiance/main.py
Outdated
| tz_convert_val=tz_convert_val) | ||
|
|
||
| return self.metdata | ||
| return self.metdata, metadata |
There was a problem hiding this comment.
@mjprilliman - you need to revert this line - other functions are expecting a br.MetObj return here, not a tuple. If you need other raw values from metadata, let's include it in the MetObj, but most of the relevant metadata details should already be included directly accessible in the MetObj. Maybe we can include an additional MetObj attribute like metadata_raw that stores the original raw metadata?
There was a problem hiding this comment.
I think that was an artifact from a previous version of this effort, and now the metadata handling is done in pvdeg and passed to the MetObj. So reverting this is no problem.
| metdata=self.metdata, location_name=location_name, | ||
| output_folder=output_folder) | ||
|
|
||
| def integrated_spectrum(self, spectra_folder): |
There was a problem hiding this comment.
@mjprilliman - we should come up with another pytest in test_spectra.py that exercise this integrated_spectrum function. I have one on my local computer that can be added to development once this gets merged...
There was a problem hiding this comment.
I'm ok with merging this into development if you think it's good to go.
Pytest update prior to merge into Dev.
cdeline
left a comment
cdeline
left a comment
There was a problem hiding this comment.
LGTM. Thanks @mjprilliman
3 participants
-Updates spectral utility functions to have more flexibility with weather data input
-Add integration function to get integrated components of lights for decomposition normalization calculations