[vulnops][data] fix: Replace unsafe pickle.loads with restricted unpickler in Qwen VL pipeline#3139
Draft
[vulnops][data] fix: Replace unsafe pickle.loads with restricted unpickler in Qwen VL pipeline#3139
Conversation
…Qwen VL data pipeline The videohandler.__call__ method used pickle.loads() directly on data from WebDataset shards, enabling arbitrary code execution via crafted pickle payloads. Replace with a RestrictedUnpickler that only allows safe built-in types (list, dict, tuple, str, int, float, etc.). The restricted unpickler is placed in a shared utility module (megatron.bridge.utils.safe_pickle) for reuse across other fixes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
yaoyu-33
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safe_pickle.pyutility with_RestrictedUnpicklerthat only allows safe built-in types (list, dict, tuple, str, int, float, bool, bytes, etc.)pickle.loads()in Qwen VLvideohandlerwithsafe_pickle_loads()to prevent arbitrary code execution from malicious WebDataset shardspickle.UnpicklingErrorif any non-whitelisted type is encounteredTest plan
🤖 Generated with Claude Code