[vulnops][misc] fix: Add allowlist validation for _target_ instantiation#3142
Draft
[vulnops][misc] fix: Add allowlist validation for _target_ instantiation#3142
Conversation
…event arbitrary code execution Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
yaoyu-33
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ALLOWED_TARGET_PREFIXESallowlist (megatron.,torch.,nvidia.,transformers.,numpy.,nemo.) to restrict which modules can be instantiated via_target_in YAML configsregister_allowed_target_prefix()API so users can extend the allowlist for their use cases_target_: os.system)Test plan
os.system,subprocess.run) are rejectedregister_allowed_target_prefix()works for extending the allowlist🤖 Generated with Claude Code