Merged
Conversation
Member
Author
|
Since we have no sensible downstream tests until oscar-system/Oscar.jl#5613 is merged, I suggest we wait a little bit longer with this. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2230 +/- ##
==========================================
+ Coverage 88.02% 88.34% +0.31%
==========================================
Files 127 127
Lines 31815 32942 +1127
==========================================
+ Hits 28004 29101 +1097
- Misses 3811 3841 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fingolfin
approved these changes
Dec 3, 2025
Member
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
We'll wait, but I'll approve this anyway so that things can move on quickly once we are ready.
Collaborator
|
CI ran but the OSCAR release job failed / was "cancelled". I restarted it. |
Member
Author
|
Thanks, @joschmitt! Once CI is green, I'll go ahead with merging and releasing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We haven't had a patch release in quite a while.