Skip to content

Feature/cleanup dependency #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2018
Merged

Feature/cleanup dependency #40

merged 2 commits into from
Feb 5, 2018

Conversation

shishirmk
Copy link
Collaborator

This pull request removes unnecessary runtime and development dependencies to gems that fast_jsonapi doesn't really need. Which include OJ and Juwelier.

Since Juwelier is removed i have updated the documentation accordingly.

This should address #7 and #32

README.md Outdated
@@ -179,59 +179,14 @@ serializer | Set custom Serializer for a relationship | ```has_many :actors, ser
## Contributing

Please follow the steps on [contribution check](https://github.com/Netflix/fast_jsonapi/blob/master/CONTRIBUTING.md).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see [CONTRIBUTING.md] for more details on contributing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@shishirmk shishirmk force-pushed the feature/cleanup_dependency branch from 57938b3 to 7612e30 Compare February 3, 2018 20:03
@shishirmk shishirmk mentioned this pull request Feb 4, 2018
@shishirmk shishirmk force-pushed the feature/cleanup_dependency branch from 7612e30 to 44aad6b Compare February 5, 2018 01:20
@shishirmk shishirmk merged commit 799499c into dev Feb 5, 2018
@shishirmk shishirmk deleted the feature/cleanup_dependency branch February 6, 2018 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants