BT Remote: Add Rename Option, simplify Bad KB BLE profile

[aaronjamt]

What's new

• This applies to the Bluetooth Remote app.
• Adds an option to rename the advertised Bluetooth device.

Addresses #410.

---

For the reviewer

• I've uploaded the firmware with this patch to a device and verified its functionality
• I've confirmed the bug to be fixed / feature to be stable

[WillyJL]

As mentioned in review comment

[aaronjamt]

Should I combine these commits into one (or at least remove the separate "revert changes to firmware" commit) and force-push or are "revert" commits okay to be merged into the main repo?

[WillyJL]

I typically squash merge pull requests, so it doesn't matter anyway :) thanks, will review soon

[aaronjamt]

I typically squash merge pull requests, so it doesn't matter anyway :) thanks, will review soon

Sounds good, thanks!

[WillyJL]

also no need to worry about rebasing, it ends up squashed anyway so i merge into pr branches just to test on latest changes and to update the changelog file, and that wont cause issues for squashing. if i have some local changes im yet to push to the pr branch tho, rebasing gets in the way :)

[aaronjamt]

also no need to worry about rebasing, it ends up squashed anyway so i merge into pr branches just to test on latest changes and to update the changelog file, and that wont cause issues for squashing. if i have some local changes im yet to push to the pr branch tho, rebasing gets in the way :)

Sounds good, won't rebase again. I just like seeing a nice tidy graph in VSCode, lol

[WillyJL]

i think ill edit this a bit more than i wanted to, wanna add a setting file so it remembers, so this profile will need to be moved outside the rename scene and be used from the beginning, similar to badkb.

[aaronjamt]

i think ill edit this a bit more than i wanted to, wanna add a setting file so it remembers, so this profile will need to be moved outside the rename scene and be used from the beginning, similar to badkb.

Would you rather I do that so you don't have to? I didn't mean to add a ton of work to your plate.

[WillyJL]

not at all, i want some fun too :D working on it rn