Add scope_for_authentication method to find records#727
Open
hubertlepicki wants to merge 1 commit into
Open
Conversation
|
This looks like it'd solve an issue I'm experiencing as well — I'd like to add some |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I was trying to do exactly as this guy over here #723
I figured I need a scope, and I do not like the
default_scopesolution.This commit uses
scope_for_authenticationmethod, if defined on given class, to find the record in question. In my case, this is implemented aswhere("deleted_at is not null")but I guess there are other use cases or conditions that you might want to apply in similar manner.Please have a loook, and if you find it useful merge. If no, no harm done, I'll keep my fork for this single app for time being until I find better solution.