Repository navigation
Preserve descriptor-array indices across compatible handle Phis - #1038
Merged
hckrman101 merged 1 commit intoNov 9, 2026
Merged
Conversation
klimovich008
force-pushed
the
codex/preserve-texture-phi-indices
branch
from
November 9, 2026 15:43
1fa00b5 to
195f201
Compare
Contributor
|
Tested on NVIDIA (RTX 3070, Windows 11), merged onto v2.0.8-rc.5 (only tests/run_all.py conflicted).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
A texture-handle Phi can select an array index from the wrong incoming branch. Vulkan can reject the resulting shader with
VUID-VkShaderModuleCreateInfo-pCode-08737because that index does not dominate its use.Why merge
GetCbufU32Phis with matching bank, base, count and default stride.Change
gpu/vk/eden/shader_recompiler/ir_opt/texture_pass.cpp: carry offsets through matching predecessor edges.tests/texture_phi_dominance_ir.cpp: check the real pass, collector and emitter.nx2/test_texture_phi_dominance.py: build and validate four synthetic cases.tests/run_all.py: register the check without replacing existing entries.Tested
python -I -B tests/run_all.py --jobs 1 --strict texture_phi_dominanceFails on the old code, passes now. The Linux regression checks selection, dominance, retained samples/outputs and Vulkan 1.3 validation. Rebased Linux/Windows CI passes; local Windows skips unavailable SPIR-V tools. No new GPU test is claimed.
Not covered
No game data is included.