Repository navigation
Builder: the ready page names both places when the build files are in a folder the player chose (rest of #623) - #1079
Merged
hckrman101 merged 1 commit intoNov 9, 2026
Conversation
… a folder the player chose (NotRexed#600) The total counted both folders and the text named only %LOCALAPPDATA%\HookshotBuilder; Show folder now opens the build files folder, the bigger one, when it was chosen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
The red "Python source checks" is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #600, #623.
This is what's left of #623, rebased on current main as asked there. #623 itself couldn't be reopened. The rest of #623 is already on main through f39868e and the later space changes (55abe59), so this PR holds only the one change main doesn't have:
Storage.WorkChosen), the text now names both places.Storage.Measure()adds the chosen work folder to the total, but the text only namedStorage.Base, so it understated where the space is. Telling the player where the space goes is what *Serious Installer Issue* Do not install 5+ GB to my appdata/local folder without asking me! #600 asked for.The change is five lines in
MainWindow.xaml.cs. I have no dotnet here, so the Windows CI job ("Hookshot Builder package and setup") is what compiles it.With 55abe59 the build files are deleted after a build unless
HOOKSHOT_KEEP_BUILD_FILES=1, so the "can be freed" part of that text mostly appears with that setting. The total still counts the chosen folder either way.