Repository navigation
fix(vulkan): release modules from rejected cache records - #1082
Merged
hckrman101 merged 1 commit intoNov 9, 2026
Merged
Conversation
bronze-ff
added a commit
to bronze-ff/Hookshot
that referenced
this pull request
Nov 9, 2026
…cache_load The check NotRexed#1082 added (2838e89) lifts program_cache_load from gpu/vk/vk_shader.cpp and compiles it against its own stand-ins. That function has called PROF_EXACT() since f226108, which the fixture does not define, so the check stops at compile time on main: "'PROF_EXACT' was not declared in this scope". The fixture now defines it as a no-op beside its other stand-ins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
Rebased this change onto
origin/mainat8b2e1d3b895a5f890dcb886d904b62d6b38df2c7, preserving the current indexed cache reader and record loading path.When a later stage in a cache record fails, earlier
VkShaderModulehandles are now destroyed and reset before the record is discarded. The cache format is unchanged. The regression fixture covers failure on the first or later module, malformed and truncated records, valid records, and independent records continuing to load.Validation
hookshot_vk.dllbuild passed: 278 seconds, zero compilation failures.origin/mainrun reported 115 passed, 7 failed, 12 skipped. The same seven checks failed on both:nx2/test_nup_verify.py,nx2/test_nup_codec.py,nx2/test_mesh_first_types.py,nx2/test_nup_paths.py,tests/test_fps_overlay_order.py,tests/test_precompile_compute_guard.py, andtests/test_program_answer_domains.py. The added regression test passed; no additional failure was observed.No game data or in-game test was used. No real-GPU validation was performed after the rebase.
This resubmission replaces PR #720, following the maintainer's request to rebase and reopen it. GitHub refused to reopen the closed original PR, so this contribution is submitted as a new independent PR.