Repository navigation
fix(vulkan): preserve guest mip levels in partial clears - #1084
Merged
hckrman101 merged 1 commit intoNov 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
Rebased this change onto
origin/mainat8b2e1d3b895a5f890dcb886d904b62d6b38df2c7.A partial clear resolves a guest mip to its physical image mip. The attachment view takes a guest mip and applies the skipped-level offset itself, so passing the already-resolved physical mip selected the wrong level. The partial-clear path now restores the guest mip before creating the view. Whole-level clears are unchanged. This change is independent of the buffer/image copy-span fix.
Validation
clang++is unavailable. The new fixture passed with GCC AddressSanitizer and UndefinedBehaviorSanitizer.hookshot_vk.dllbuild passed: 276 seconds, zero compilation failures.origin/mainrun reported 115 passed, 7 failed, 12 skipped. The same seven checks failed on both:nx2/test_nup_verify.py,nx2/test_nup_codec.py,nx2/test_mesh_first_types.py,nx2/test_nup_paths.py,tests/test_fps_overlay_order.py,tests/test_precompile_compute_guard.py, andtests/test_program_answer_domains.py. The added regression test passed; no additional failure was observed.The fixture uses synthetic texture objects, instrumented view mapping, and Vulkan command spies. It does not execute a Vulkan driver. No real-GPU or in-game test was performed after the rebase.
This resubmission replaces PR #754, following the maintainer's request to rebase and reopen it. GitHub refused to reopen the closed original PR, so this contribution is submitted as a new independent PR.