Repository navigation
Release buffers after fallback initialization failure - #1087
Merged
NotRexed merged 3 commits intoNov 10, 2026
Merged
Conversation
Free only confirmed unpublished allocations after payload creation failure or a zero required device address. Preserve successful reuse and the existing tried/no-retry behavior. Exercise the actual production function with authored allocation/BDA failures and register its portable regression. Assisted-by: OpenAI Codex Co-Authored-By: OpenAI Codex <noreply@openai.com>
Preserve both source-check registrations and extract the current production TLS ownership helper without changing the nine allocation-failure assertions.
Owner
|
This landed in the v2.0.12 branch (merged there for testing; it reaches |
Owner
|
Reopened: closing this was a mistake on my side. It was tested in the v2.0.12 branch, and it will be merged into main here, so it shows as merged. Sorry for the noise. |
NotRexed
added a commit
to nicholasgower/Hookshot
that referenced
this pull request
Nov 10, 2026
…otRexed#1087's per-program cleanup, its now unused lambda dropped; the cleanup test follows the per-thread buffers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fallback initialization retained confirmed allocations when payload creation failed or a required device address was zero. The failed entry was already marked tried, so those allocations could not be reused.
Release only confirmed, unpublished allocations on these failures, clear their handles/addresses, and reject a zero required task-payload address. Successful initialization/reuse and existing no-retry behavior remain unchanged.
The refresh retains upstream build/render behavior and its TLS_OBJECT ownership change. The fixture now extracts the actual TLS ownership helpers and accesses the production fallback_buffers() map; both automatic-runner registrations are preserved.
Validation:
Refs #1072. This fixes a source-proven failure-path leak; it does not establish that report’s RAM-growth or RADV-crash cause. No real Vulkan allocation, GPU/game run, full renderer build, or in-flight resource-retirement change was tested. Shared-buffer work such as #1023 remains separate.
All eight hosted validation checks pass on current head
f2d1fc5; release publishing is skipped for the PR.