[t0masz407]

Supersedes #680, which was closed for a conflict with main: rebased onto current main, plus the window icon (below).

What

make_game.py copied hot_funcs.txt, hot_order.txt, hookshot_pieces.prof, hookshot.res and work/image/chunks.txt from the tools folder with shutil.copy2, which takes the source's mode along. A new copy_writable() copies the bytes only (also used for the window icon hookshot.png, which copy2 copied into the game folder the same way), and first makes an existing read-only copy writable again (so a work folder broken by an earlier build recovers by itself).

Why

From a read-only install the copies in the work folder were read-only too, and lift.py then stopped with

PermissionError: [Errno 13] Permission denied: '/home/<user>/.cache/hookshot-builder/image/chunks.txt'

on that build and every later one. The second build of a game folder stopped the same way on its read-only hookshot.png:

PermissionError: [Errno 13] Permission denied: '/home/<user>/Games/Hookshot/hookshot.png'

This happens with the Linux AppImage unpacked into the Nix store on NixOS (everything there is r--r--r--), and would with any packaged read-only tools folder (a distro package, a Flatpak). The filecmp check before the copy compares contents, so copy2's timestamps were never needed.

Tested

NixOS, the v2.0.1 / honest-eta AppImage's tools in the Nix store: the build that stopped at lift.py before now completes, and the game runs. On v2.0.7 a rebuild of an existing game folder stopped at hookshot.png and completes with the change. tests/test_copy_writable.py copies a read-only source over a read-only leftover and appends to the result as lift.py does (fails on main, passes here); tests/run_all.py picks it up; it also checks that the icon is no longer copied with copy2. tests/test_make_game_cache.py still passes.

🤖 Generated with Claude Code