Repository navigation
fix(vulkan): bound configured frame waits to ring capacity - #1113
Merged
Merged
Conversation
Parse the opt-in frame count with strtol and clamp it before casting or indexing the fixed ring. Preserve disabled settings, numeric prefixes, read-once behavior and valid wait ordering. Assisted-by: OpenAI Codex Co-Authored-By: OpenAI Codex <noreply@openai.com>
Keep the frame-wait fixture strict while matching the production CRT definition needed by MSVC-target Clang. Preserve all parsing, bounds and ordering assertions. Assisted-by: OpenAI Codex Co-Authored-By: OpenAI Codex <noreply@openai.com>
Owner
|
This landed in the v2.0.12 branch (merged there for testing; it reaches |
Owner
|
Reopened: closing this was a mistake on my side. It was tested in the v2.0.12 branch, and it will be merged into main here, so it shows as merged. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RX_VK_WAIT_GPUused an unchecked parsed count to index an eight-entry ring. A positive setting above eight could read and write outside that array. Bound the read-once setting to the actual ring capacity before converting it tointor indexing.strtolsafely handles values outside the integer range; whitespace, signs and numeric prefixes remain accepted.Unset, zero, negative and nonnumeric settings remain disabled. Counts one through eight keep their timeline-value wait order. An oversized setting prints one diagnostic showing the effective limit, so a player requesting 12 frames can see that the ring holds eight. This fixes an opt-in configuration bounds bug; it does not explain issue #1106's setting of zero or claim a default-performance improvement.
The authored regression extracts the actual initialization and complete replay wait block, adding a pre-index observer so the original-source negative rejects an out-of-range count without an invalid memory access. All 18 cases cover valid counts, disabled inputs, numeric prefixes, oversized/overflow inputs, read-once behavior, wait ordering and one-time diagnostics.
Validation on
01f4317, merged with upstream7dbdcdc:-Wall -Wextra -Werror. The strict focused runner passes with zero failures or skips.8b2e1d3, the bounds regression previously rejected representable counts9and2147483647before indexing; 14 controls passed. Originalatoioverflow inputs and invalid ring accesses were not executed.No Vulkan device, game, shader compiler, actual GPU wait or physical presentation measurement is used by this fixture. Prior Windows MSVC-target Clang validation passed all 18 original bounds cases; that target has not been rerun for the added diagnostic.