Repository navigation
fix(linux): exit after unexpected display startup failure - #1128
Merged
NotRexed merged 4 commits intoNov 10, 2026
Merged
Conversation
Return a distinct initialization error and stop before game startup when SDL cannot load or initialize. Flush the window creation error and exit instead of continuing invisibly offscreen. Preserve explicit headless startup. Add seven production-extraction regressions covering the three failures and four existing-behavior controls. Assisted-by: OpenAI Codex Co-Authored-By: OpenAI Codex <noreply@openai.com>
Owner
|
This landed in the v2.0.12 branch (merged there for testing; it reaches |
Owner
|
Reopened: closing this was a mistake on my side. It was tested in the v2.0.12 branch, and it will be merged into main here, so it shows as merged. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1116, reported by @AL-33.
When SDL cannot load, initialize, or create a window, Hookshot can continue invisibly with audio. A failed window creation starts an offscreen renderer and sleeps indefinitely. Return a distinct initialization error and exit with status
1after logging and flushing the diagnostic. All three failures also print their reason to stderr. ExplicitHOS_HEADLESSand successful visible startup retain their behavior.Shader preparation remains usable without SDL or a display: the POSIX entry point recognizes
--prepare-shadersbefore display initialization, then lets the preparation worker finish or report its existing no-Vulkan exit3. Values supplied to--romfsand--userare skipped when identifying that flag.The report identifies a missing
libvulkan.so.1. Supplying that dependency and NixOS packaging remain separate work.Validation on
8a72a7d, merged with upstream7dbdcdc:-Wall -Wextra -Werror. The focused strict runner passes with zero failures or skips.--prepare-shaders.8b2e1d3.The fixture extracts the production initialization/start functions and POSIX entry point, plus the display loop's window-startup prefix. SDL, threading, renderer and termination are authored stubs; preparation worker success and exit
3are authored outcomes. Real SDL/NixOS execution, Vulkan shader preparation, event/render processing and actual thread concurrency remain untested by this fixture. No game data is included.